Add packed_at() to PreProcessed Column Enum #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Gali-StarkWare
requested review from
alon-f
and removed request for
shaharsamocha7
Gali-StarkWare
changed the base branch from
gali/move_preprocessed_structs
to
graphite-base/360
Gali-StarkWare
force-pushed
the
graphite-base/360
branch
from
32d6c02 to
e9f0546
Compare
Gali-StarkWare
force-pushed
the
gali/add_packed_at
branch
from
e1c4740 to
7ce3f85
Compare
Gali-StarkWare
force-pushed
the
gali/add_packed_at
branch
from
7ce3f85 to
1b92ae4
Compare
shaharsamocha7
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @alon-f)
alon-f
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare)
stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 59 at r1 (raw file):
pub fn packed_at(&self, vec_row: usize) -> PackedM31 { match self { PreProcessedColumn::IsFirst(column) => column.packed_at(vec_row),
blocked
alon-f
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is